-
Notifications
You must be signed in to change notification settings - Fork 117
[DENG-9732] Filter out remotecontent events from event etl #8140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sean-rose
reviewed
Sep 23, 2025
sql/moz-fx-data-shared-prod/telemetry_derived/event_events_v1/query.sql
Outdated
Show resolved
Hide resolved
sql_generators/glean_usage/templates/event_monitoring_aggregates_v1.query.sql
Outdated
Show resolved
Hide resolved
sql_generators/glean_usage/templates/event_monitoring_aggregates_v1.query.sql
Outdated
Show resolved
Hide resolved
sql_generators/glean_usage/templates/event_monitoring_aggregates_v1.query.sql
Outdated
Show resolved
Hide resolved
sql_generators/glean_usage/templates/event_monitoring_aggregates_v1.query.sql
Outdated
Show resolved
Hide resolved
sql_generators/glean_usage/templates/events_stream_v1.query.sql
Outdated
Show resolved
Hide resolved
8b81bbf
to
a8a3b0a
Compare
This comment has been minimized.
This comment has been minimized.
Integration report for "Merge branch 'main' into benwu/filter-remotecontent-143"
|
sean-rose
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This filters the high volume
uptake.remotecontent.result
events from legacy and glean event tables. This might fix theevent_monitoring_aggregates_v1
failures but I'm still waiting for the queries to finish.I also rearranged the
event_monitoring_aggregates_v1
query a bit to aggregate events per ping before aggregating per app since I found that it uses slightly less slot time and shuffleRelated Tickets & Documents
Reviewer, please follow this checklist